feat(toDash)!: Add support for generating manifests for Post Live DVR videos #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… videos BREAKING CHANGES: The `duration` property in `StreamingInfo` has been replaced by the asynchronous `getDuration()` function, as getting the duration of Post Live DVR videos requires making a fetch request.
LuanRT
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While YouTube does provide DASH manifests for Post Live DVR videos, those are limited to only the last few hours of the live stream. YouTube has also been known to return broken DASH manifests for Post Live DVR videos e.g. saying that a 12 hour long video is 4 hours long but that the segments start at hour 9 (logically the offset cannot be larger than the entire video is supposed to be).
Post Live DVR videos can be found by using the script in the testing section here: FreeTubeApp/FreeTube#3872
BREAKING CHANGES: The
durationproperty inStreamingInfohas been replaced by the asynchronousgetDuration()function, as getting the duration of Post Live DVR videos requires making a fetch request.