perf: Cache deciphered n-params by info response #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for web responses at least, the
adaptiveFormatsand theformatseach share one n-param value (two in total), per/playercall (Innertube#getInfoandInnertube#getBasicInfoin YouTube.js). This pull request introduces a response level cache, meaning that calling.decipheronFormatobjects from the same response multiple times, will now use the already deciphered n-param, as long as it is the same as one of the ones in the cache. The way it is designed, it doesn't make any assumptions on the number of n-param values, so if YouTube starts using a unique one for every URL, this code will continue to work, it will just make the cache useless.In my testing this resulted in the
toDashfunction being on average more than 50% faster.