feat(VideoInfo): support iOS client #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request doesn't adjust the ClientType enum |
|
YouTube.js/src/core/Session.ts Line 15 in 0dda97e |
This enum doesn't seem to influence anything, as if it was deprecated. I can still update it and open a PR if you'd like! :). |
|
That's an easy fix. Feel free to open another PR if you want @ronnie-codes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging f4e0f30 as my true north, this PR adds support for HLS streaming with an iOS user agent. The user agent is 100% reliable. I've been using it in my Mac/iPad/iPhone client for a number of months now and it always generates the
hls_manifest_url.