Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.1.0 - Playlist parser class ignores thumbnailRenderer #423

Closed
4 tasks done
Rikthepixel opened this issue Jun 28, 2023 · 2 comments · Fixed by #424
Closed
4 tasks done

5.1.0 - Playlist parser class ignores thumbnailRenderer #423

Rikthepixel opened this issue Jun 28, 2023 · 2 comments · Fixed by #424
Labels
bug Something isn't working

Comments

@Rikthepixel
Copy link
Contributor

Steps to reproduce

  1. Get a channel object
  2. Search for playlists
  3. Look into the result for any playlists
    3.1. Look non-parsed response to see that thumbnailRenderer exists

Example
image

This bug was encountered in the Freetube repo in this pull request:
FreeTubeApp/FreeTube#3710 (comment)

Failure Logs

N.A.

Expected behavior

For Playlist instances to have an (optional) thumbnail_renderer prop just like GridPlaylist

Current behavior

The Playlist class ignores the thumbnailRenderer prop

Version

Default

Anything else?

It seems that the thumbnailRenderer node is not always set, for instance on Mix playlists (aka playlists that users didn't make). So if the thumbnailRenderer node should be added it should be optional/possibly undefined.

image

Checklist

  • I am running the latest version.
  • I checked the documentation and found no answer.
  • I have searched the existing issues and made sure this is not a duplicate.
  • I have provided sufficient information.
@Rikthepixel Rikthepixel added the bug Something isn't working label Jun 28, 2023
@Rikthepixel
Copy link
Contributor Author

I am planning to add this prop myself in a PR

@Rikthepixel Rikthepixel mentioned this issue Jun 28, 2023
Merged
@Rikthepixel
Copy link
Contributor Author

Created pull request #424 to fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Playlist): Add thumbnail_renderer on Playlist when response includes it
1 participant
@Rikthepixel