Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable importHelpers in tsconfig to reduce output size #378

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

absidue
Copy link
Collaborator

@absidue absidue commented Apr 8, 2023

Description

Currently the typscript compiler adds the necessary polyfills/helpers to each file individually, this results in a lot of duplicated code. By enabling the importHelpers option in the tsconfig, it will instead add imports for the helpers to the files. The savings are quite large, so it definitely seems worth it.

Here are the before and after results of the bundles:

before after

Here are the before and after results for FreeTube which uses the youtubei.js/web export, so the modules in the dist directory, instead of one of the bundles:
freetube-before freetube-after

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@LuanRT LuanRT merged commit 0b301de into LuanRT:main Apr 8, 2023
@absidue absidue deleted the tsconfig-import-helpers branch April 8, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants