fix(toDash): Generate unique Representation ids #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like video.js changed something on their end since I added support for multiple audio tracks to the DASH manifest, now it seems to require unique ids for all representations, otherwise it just silently fails to switch audio tracks :(.
This was tested in FreeTube with video.js, hopefully this doesn't break shaka (I couldn't find anything in the spec that mandated that the ids consist of only digits, so I'm not expecting anything to break).
Here is a video that can be used as a test, it contains 3 English audio tracks, the main one, one with the interviewee dubbed and a third one with audio descriptions: https://youtu.be/Kn56bMZ9OE8
Type of change
Checklist: