Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toDash): Generate unique Representation ids #366

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

absidue
Copy link
Collaborator

@absidue absidue commented Mar 22, 2023

Description

It looks like video.js changed something on their end since I added support for multiple audio tracks to the DASH manifest, now it seems to require unique ids for all representations, otherwise it just silently fails to switch audio tracks :(.

This was tested in FreeTube with video.js, hopefully this doesn't break shaka (I couldn't find anything in the spec that mandated that the ids consist of only digits, so I'm not expecting anything to break).

Here is a video that can be used as a test, it contains 3 English audio tracks, the main one, one with the interviewee dubbed and a third one with audio descriptions: https://youtu.be/Kn56bMZ9OE8

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link
Owner

@LuanRT LuanRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with shaka and it worked correctly.

@LuanRT LuanRT merged commit a8b507e into LuanRT:main Mar 22, 2023
@absidue absidue deleted the unique-representation-ids branch March 22, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants