-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Parser)!: general refactoring of parsers #344
Conversation
- Replace non standard author type with Author class - Remove redundant code
1308382
to
e248ba5
Compare
You might have to rebase this pull request on top of the main branch so that you don't break #351. This pull request doesn't pass an |
Fixed. Already did a merge, just forgot to update the toDash method of MediaInfo. |
Thanks for fixing that, also it's probably worth changing the start of the title from |
https://github.com/googleapis/release-please#how-can-i-fix-release-notes alternatively you can add a section like this to the pull request description to override the message that release please uses. That way you could also list the specific things that are breaking changes (tried it in #351 but need to wait for release please to run again before I know if it worked) |
Seems like it did. |
I just realized I already did merge NavigatableText and Text for #310 oops |
You can do the commit override stuff after a pull request is merged too. Release-please digs through all pull requests merged since the last release every time it runs (when a commit is pushed to the main branch either directly or by a pull request getting merged) |
Description
General refactor of parsers to cleanup the codebase.
Breaking Changes
Checklist: