Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TopicChannelDetails): avatar and subtitle parsing #302

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

absidue
Copy link
Collaborator

@absidue absidue commented Feb 1, 2023

Description

This pull request fixes the title and subtitle properties on the TopicChannelDetails being identical and the avatar array being empty.

I haven't come across a case where data.thumbnail actually existed but I've left it in there just in case there is an edge case that uses it.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@LuanRT LuanRT merged commit d612590 into LuanRT:main Feb 1, 2023
@absidue absidue deleted the topic-channel-details-parsing branch February 1, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants