Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve live chat's initial data parsing #282

Closed
4 tasks done
LuanRT opened this issue Jan 9, 2023 · 1 comment · Fixed by #285
Closed
4 tasks done

Improve live chat's initial data parsing #282

LuanRT opened this issue Jan 9, 2023 · 1 comment · Fixed by #285
Assignees
@LuanRT
Labels
enhancement New feature or request

Comments

@LuanRT
Copy link
Owner

LuanRT commented Jan 9, 2023

Describe your suggestion

Looks like the emojis property from the initial data is not being parsed correctly, its image array is not converted to an array of Thumbnail. Also, a few nodes are still using Parser#parse which causes their types to be unknown.

Other details

No response

Checklist

  • I am running the latest version.
  • I checked the documentation and found no answer.
  • I have searched the existing issues and made sure this is not a duplicate.
  • I have provided sufficient information.
@LuanRT LuanRT added the enhancement New feature or request label Jan 9, 2023
@LuanRT LuanRT self-assigned this Jan 9, 2023
@LuanRT
Copy link
Owner Author

LuanRT commented Jan 9, 2023

Also, should probably add support for filtering the live chat by “Top chat” and “Live chat”.

@LuanRT LuanRT mentioned this issue Jan 10, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuanRT LuanRT

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: improve livechat parser & add remaining action nodes LuanRT/YouTube.js
1 participant
@LuanRT