Can no longer use extensionDependencies because of Proposed API / VS Code 1.54.1

[Ketho]

Describe the bug
My EmmyLua extension no longer works, in the VS marketplace and when trying to debug it.
The error shows your extension is using "Proposed API" but it does not actually use that right?
This bug seems to happen since the VS Code 1.54.0 or 1.54.1 update.

To Reproduce
Steps to reproduce the behavior: (see https://github.com/Ketho/test-sumneko-lua)

1. Create a new extension with yo code

2. Add the extension dependency.

"extensionDependencies": [
	"sumneko.lua"
]

3. Try to debug with F5. It fails to activate.

Environment (please complete the following information):

• OS: Windows 10
• Is WSL remote? No
• Client: VSCode

Additional context
I rolled back VS Code to 1.53.2 and I could successfully debug the test extension again.
Same for my EmmyLua extension (ketho.wow-api 0.3.3 with sumneko.lua 1.17.4)

There seems to be something wrong with VS Code 1.54.0 or 1.54.1 that breaks extensionDependencies

Proposed API
I also tried to enable Proposed API as described on https://code.visualstudio.com/api/advanced-topics/using-proposed-api

• Installed Visual Studio Code Insiders.
• Added "enableProposedApi": true to package.json for both the sumneko.lua and test extensions.
• Copied vscode.proposed.d.ts to the project source location with npx vscode-dts dev
• Added "--enable-proposed-api" to my launch.json args,

But I failed, nothing fixed the error. This is the first time I tried to enable the Proposed API though.

[Yakehira]

Same here, error in vscode log (extension host) but sumneko extension still works, but extension (WoW API) depending on sumneko can not initialize if extensionDependencies is set to sumneko extension, started with 1.54.0 or 1.54.1.

[2021-03-06 20:19:45.668] [exthost] [error] Activating extension sumneko.lua failed due to an error:
[2021-03-06 20:19:45.669] [exthost] [error] Error: [sumneko.lua]: Proposed API is only available when running out of dev or with the following command line switch: --enable-proposed-api sumneko.lua
	at f (c:\Users\Home\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:87:74959)
	at Object.p [as checkProposedApiEnabled] (c:\Users\Home\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:87:74906)
	at Object.get extensionId [as extensionId] (c:\Users\Home\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:91:13240)
	at activate (c:\Users\Home\.vscode\extensions\sumneko.lua-1.17.4\client\out\extension.js:16:39)
	at Function._callActivateOptional (c:\Users\Home\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:91:14037)
	at Function._callActivate (c:\Users\Home\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:91:13714)
	at c:\Users\Home\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:91:11746
	at processTicksAndRejections (internal/process/task_queues.js:97:5)
	at async Promise.all (index 0)````

[Ketho]

Actually it does not seem related to extensionDependencies, just trying to debug any extension while having sumneko.lua installed and opening a Lua file already shows that error with VS Code 1.54.1

[sumneko]

I have no idead. The only place where related functions are used is https://github.com/sumneko/vscode-lua/blob/0ca56305cbe34e03654231be32222eb2824675ac/client/src/languageserver.ts#L150 . However, after I tried to remove it, this error still appeared.

[sumneko]

fixed by LuaLS/vscode-lua@f79d268

[Ketho]

Thank you very much~