Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename workspace.userThirdParty #1384

Closed
carsakiller opened this issue Jul 25, 2022 · 3 comments
Closed

Rename workspace.userThirdParty #1384

carsakiller opened this issue Jul 25, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@carsakiller
Copy link
Collaborator

The Problem

I am currently reworking the documentation for library support and ever since I learned of the workspace.userThirdParty setting a couple months ago, I have disliked the name.

It is an incredibly useful feature hidden behind a bad name

The name "Third Party Directory" that is used in the wiki is also a poor choice I feel as it is more than just a directory, that is misleading, it functions closer to an extension and needs a name more fitting of its function.

Possible Solution

A name I have been considering is "Environment Emulators" which could be shortened to envEmulators for the configuration files. I'm still not sure about this name but I think it fits the purpose way better.

They can then be referred to as "third party environment emulators" for the libraries included in meta/3rd/ and as "user environment emulators" for the ones defined in workspace.envEmulators.

The third-party "directories" currently included in meta/3rd/ can continue to be under that directory, I just think the setting and naming of the feature is in desperate need of a change.


Also, if this is to be renamed, it should probably happen at the same time as #1364 to minimize breaking updates.

@sumneko sumneko added the enhancement New feature or request label Jul 25, 2022
@sumneko
Copy link
Collaborator

sumneko commented Jul 25, 2022

Look at my nickname and the name of this project, you can understand my accomplishment on naming.

@carsakiller
Copy link
Collaborator Author

Well I know English is not your first language so it is absolutely no problem. I am glad to help improve the English translations and make things as easy to understand as possible.

@carsakiller
Copy link
Collaborator Author

This should be discussed in #1404

@carsakiller carsakiller closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants