Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ About
Hi @JoshCoady, the PR #9 introduce by @denis-trofimov was a breaking change:
I encountered this breaking change, bumping from 1.0.1 to 1.0.2 give the result:
By escaping the
\n
they are not correctly interpreted by Slack anymore.This is my github actions:
I agree with @hasier the right way is to Jsonify the payload, this is what we were doing.
toJSON
I would say that @denis-trofimov missed this part, his PR manually escape the
\n
character cause he had trouble with, but the same issue could occur with some other character and not, the github actions leave us with a broken state where\n
I let
to use the correct line delimiter, because I think it still can be an improvement ; but I removed the escaping.
Thanks