Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI settings not saving #1282

Open
The-Kitai opened this issue Dec 24, 2024 · 6 comments
Open

GUI settings not saving #1282

The-Kitai opened this issue Dec 24, 2024 · 6 comments

Comments

@The-Kitai
Copy link

The-Kitai commented Dec 24, 2024

When clicking save on the GUI on linux(Pop_OS), its not saving the settings. Everything else seems to be working. The screen pops up, i type in a file name, and click save, get ditto. Can just keep hitting save and nothing happens.

@LostRuins
Copy link
Owner

Is this a new issue? Or did it happen in earlier versions too? The save/load dialog is triggered by Tkinter of which we recently upgraded.

@The-Kitai
Copy link
Author

I just started using popos. Not sure.

@LostRuins
Copy link
Owner

Alright, can you see if there are any errors visible in the terminal?

@syntheticgio
Copy link

I can verify that I'm also seeing this issue. I click on save, the file browser pops up, I navigate to the directory that I want to save the kcpps file in, enter in a valid file name, and then clicking on the save button doesn't do anything. It doesn't dismiss the window or anything, it just does nothing. Cancel does dismiss the window. I verified that the file wasn't saved and that the window just wasn't dismissed. Other than this everything appears to work fine with me being able to load a variety of models and use them, including with the API.

I'm using the koboldcpp exec file (version 1.80.3), and am on Ubuntu (24.04).

There are no errors visible in the terminal (I've tried running with --debugmode but that just loads up a file selector for a model, so bypasses this GUI - although I'm happy to try if there is something else I can specify).

I'm not familiar with koboldcpp's codebase, but if you wanted to point me to approximately where in the code this is at I could try to take a look. Almost certainly would be faster if you have the time, but happy to try to help out. :)

@LostRuins
Copy link
Owner

Hi, if you'd like to take a look, check out the function save_config_gui() at https://github.com/LostRuins/koboldcpp/blob/concedo/koboldcpp.py#L3930 which is triggered when trying to save a kcpps.

@syntheticgio
Copy link

Thanks, I'll take a look this week and see if I can figure out what is going on since I'm able to replicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants