You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
In common_lab, in insert_from_name method, first and last names are obtained from splitting full_name by space. That is not a case that fit all scenarios and should be changed. For example, There is "Kyun Hyun Lee" whose first name is "Kyu Hyun" (yes, "Hyun" is not his middle name) and last name is "Lee". There is also a case like "Barbara Di Eugienio" whose first name is "Barbara" and last name "Di Eugenio". This illustrates why splitting by space is not an effective solution to obtaining first and last names.
Ideally, full_name object should never be requested and user should be asked to give first name and last names separately. I will think of a way to address this issue without breaking existing functionality.
To Reproduce
Got the Notebook Tutorials. On the 0th item, search for the cell with -
# create a new team
# change team_name to something unique
# change team_members
# test_description is optional
LabTeam().create_new_team(team_name='Beans',
team_members=['Alison Comrie'],
team_description='test')
Insert "Kyu Hyun Lee" as a team member (close to "Alison Comrie")
Expected behavior
User asked to specifically mention first and last names rather than give a full name
The text was updated successfully, but these errors were encountered:
This is a bigger discussion as there is no way to identify a last name if a team member first and last name together (full_name) have two or more spaces. The solution I recommend is to make full_name be a dictionary with keys - first_name and last_name.
Description
In common_lab, in insert_from_name method, first and last names are obtained from splitting full_name by space. That is not a case that fit all scenarios and should be changed. For example, There is "Kyun Hyun Lee" whose first name is "Kyu Hyun" (yes, "Hyun" is not his middle name) and last name is "Lee". There is also a case like "Barbara Di Eugienio" whose first name is "Barbara" and last name "Di Eugenio". This illustrates why splitting by space is not an effective solution to obtaining first and last names.
Ideally, full_name object should never be requested and user should be asked to give first name and last names separately. I will think of a way to address this issue without breaking existing functionality.
To Reproduce
Got the Notebook Tutorials. On the 0th item, search for the cell with -
Insert "Kyu Hyun Lee" as a team member (close to "Alison Comrie")
Expected behavior
User asked to specifically mention first and last names rather than give a full name
The text was updated successfully, but these errors were encountered: