Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabMemberInfo should not ask for full_name #304

Closed
zoldello opened this issue Jul 29, 2022 · 2 comments
Closed

LabMemberInfo should not ask for full_name #304

zoldello opened this issue Jul 29, 2022 · 2 comments
Assignees
Labels
bug Something isn't working common

Comments

@zoldello
Copy link
Collaborator

zoldello commented Jul 29, 2022

Description
In common_lab, in insert_from_name method, first and last names are obtained from splitting full_name by space. That is not a case that fit all scenarios and should be changed. For example, There is "Kyun Hyun Lee" whose first name is "Kyu Hyun" (yes, "Hyun" is not his middle name) and last name is "Lee". There is also a case like "Barbara Di Eugienio" whose first name is "Barbara" and last name "Di Eugenio". This illustrates why splitting by space is not an effective solution to obtaining first and last names.

Ideally, full_name object should never be requested and user should be asked to give first name and last names separately. I will think of a way to address this issue without breaking existing functionality.

To Reproduce
Got the Notebook Tutorials. On the 0th item, search for the cell with -

# create a new team
# change team_name to something unique
# change team_members
# test_description is optional
LabTeam().create_new_team(team_name='Beans',
                          team_members=['Alison Comrie'],
                          team_description='test')

Insert "Kyu Hyun Lee" as a team member (close to "Alison Comrie")

Expected behavior
User asked to specifically mention first and last names rather than give a full name

@zoldello
Copy link
Collaborator Author

zoldello commented Sep 7, 2022

This is a bigger discussion as there is no way to identify a last name if a team member first and last name together (full_name) have two or more spaces. The solution I recommend is to make full_name be a dictionary with keys - first_name and last_name.

@edeno edeno added common bug Something isn't working and removed bug Something isn't working labels Oct 13, 2023
@edeno edeno assigned CBroz1 and unassigned zoldello Dec 23, 2023
@CBroz1
Copy link
Member

CBroz1 commented Feb 21, 2024

I believe this was addressed by the new decompose_name in #822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working common
Projects
None yet
Development

No branches or pull requests

3 participants