Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpikeSortingOutput calls non-existent method #1077

Closed
CBroz1 opened this issue Aug 22, 2024 · 1 comment · Fixed by #1083
Closed

SpikeSortingOutput calls non-existent method #1077

CBroz1 opened this issue Aug 22, 2024 · 1 comment · Fixed by #1083
Assignees
Labels
bug Something isn't working spike sorting

Comments

@CBroz1
Copy link
Member

CBroz1 commented Aug 22, 2024

#807 edited SpikeSortingOutput.get_spike_indicator to call cls.fetch_spike_data here

This function exists as part of SortedSpikesGroup, but not SpikeSortingOutput or any part-parents.

get_firing_rate also relies on get_spike_indicator. Should we implement the dependency or remove these methods?

@CBroz1 CBroz1 added bug Something isn't working spike sorting labels Aug 22, 2024
@samuelbray32
Copy link
Collaborator

I think the call just needs to be changed to SpikeSortingOutput().get_spike_times(key)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spike sorting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants