Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise mixin structure to reflect table types #1075

Open
CBroz1 opened this issue Aug 20, 2024 · 0 comments
Open

Revise mixin structure to reflect table types #1075

CBroz1 opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request infrastructure Unix, MySQL, etc. settings/issues impacting users

Comments

@CBroz1
Copy link
Member

CBroz1 commented Aug 20, 2024

The mixin class has expanded to include a lot of features

  • Long distance restrictions
  • thread checking
  • adjusted populate
  • fetching nwb
  • deletes
    • delete downstream parts (no longer needed after DJ 14.2)
    • check delete permissions
  • Exports

Moving forward, this might be easier to navigate if broken into classes reflecting our conceptual table types: data, selection, params.

From there, we could add methods like insert_default to SpyglassParams, which would inherit both SpylgassMixin and dj.Lookup.

Possible features...

  • insert_default for params
  • insert_with_default for selection
  • ...
@CBroz1 CBroz1 self-assigned this Aug 20, 2024
@CBroz1 CBroz1 added enhancement New feature or request infrastructure Unix, MySQL, etc. settings/issues impacting users labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Unix, MySQL, etc. settings/issues impacting users
Projects
None yet
Development

No branches or pull requests

1 participant