Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicast Class B Session request command fails #22

Closed
HernandoSergio opened this issue Nov 2, 2023 · 2 comments
Closed

Multicast Class B Session request command fails #22

HernandoSergio opened this issue Nov 2, 2023 · 2 comments

Comments

@HernandoSergio
Copy link

HernandoSergio commented Nov 2, 2023 •
edited
Loading

The Multicast Class B session request command fails.

https://github.com/Lora-net/SWL2001/blob/45e19e5bf783bf874b8c9825b76c4c5befa8bcba/smtc_modem_core/lorawan_packages/fuota_packages/lorawan_remote_multicast_setup_package.c#L890C1-L897C25

The validation of the frequency and the DR is done wrong, it shoul be checked with "ERRORLORAWAN" as the api validation functions return "OKLORAWAN" (0) or "ERRORLORAWAN" (-1) instead of true or false.
@HernandoSergio HernandoSergio changed the title Remote Multicast Setup command fails Multicast Class B Session request command fails Nov 2, 2023
@lbm-team
Copy link
Contributor

Hi @HernandoSergio
Thanks for your message.
Good catch!
This issue will be solved in next LBM release.

@lbm-team
Copy link
Contributor

Hi @HernandoSergio

This issue is now fixed in new v4.3.0 release and mentioned in CHANGELOG.

Once more thanks for your report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lbm-team @HernandoSergio