Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SpongyCastle #271

Closed
LossyDragon opened this issue Aug 20, 2024 · 0 comments · Fixed by #312
Closed

Deprecate SpongyCastle #271

LossyDragon opened this issue Aug 20, 2024 · 0 comments · Fixed by #312

Comments

@LossyDragon
Copy link
Collaborator

Reference: #261

Spongy Castle is old and hasn't been updated since 2017. There could be a risk for security issues using it, though I am no expert with the Castles to know how much integration is there just for a Cipher instance at minimum.

This was a legacy support Android API running lower than Honeycomb. Google has since renamed their BC package since; even though that is now deprecated too.

Using normal BouncyCastle for Android is recommended based on many discussions while researching this subject. Android development has a support floor for API 21 (API 24 is starting to become the new floor too with dependencies) so this widens the gap from the original BC issue earlier versions of android had.

See: https://stackoverflow.com/a/66323575/13225929

Solution:
Keep SC as an option to use, but adjust CrytpoHelper to look for BC first if running android.
Update wiki and readme to reflect changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant