Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all AdminMenus use AdminMenuNavigationProviderBase (OSOE-929) #898

Open
Piedone opened this issue Dec 4, 2024 · 0 comments
Open

Make all AdminMenus use AdminMenuNavigationProviderBase (OSOE-929) #898

Piedone opened this issue Dec 4, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Piedone
Copy link
Member

Piedone commented Dec 4, 2024

AdminMenuNavigationProviderBase in Helpful Libraries simplifies implementing an admin INavigationProvider. Go over all INavigationProvider implementations and for those that target the "admin" menu, make them use AdminMenuNavigationProviderBase. For any INavigationProvider implementations that don't target the admin menu, check if they'd benefit from using NavigationProviderBase.

Jira issue

@Piedone Piedone added the good first issue Good for newcomers label Dec 4, 2024
@github-actions github-actions bot changed the title Make all AdminMenus use AdminMenuNavigationProviderBase Make all AdminMenus use AdminMenuNavigationProviderBase (OSOE-929) Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant