-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OFFI-149: HttpContent and ZipArchive extensions, UserReadableException #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wAsnk If you are satisfied with the HL and OSOCE PRs, please merge them ahead of time. This is because "Upgrade to Orchard Core 2.1.2" of OSOE-903 is to be merged in very soon (I was just reminded to do the second review pass for it) and I don't want to delay this issue with having to do another unnecessary OC upgrade in OFFI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no suggestions.
Files not reviewed (4)
- Lombiq.HelpfulLibraries.Common/Docs/Exceptions.md: Evaluated as low risk
- Lombiq.HelpfulLibraries.Common/Exceptions/UserReadableException.cs: Evaluated as low risk
- Lombiq.HelpfulLibraries.Common/Extensions/ZipArchiveExtensions.cs: Evaluated as low risk
- Lombiq.HelpfulLibraries.Common/Readme.md: Evaluated as low risk
Comments skipped due to low confidence (3)
Lombiq.HelpfulLibraries.AspNetCore/Extensions/HttpContentExtensions.cs:31
- [nitpick] The variable name 'xml' is misleading. It should be renamed to 'fileContent'.
var xml = new ByteArrayContent(content);
Lombiq.HelpfulLibraries.AspNetCore/Extensions/HttpContentExtensions.cs:54
- The 'mediaType' parameter should be checked for null before proceeding to avoid a potential null reference exception.
string mediaType = null)
Lombiq.HelpfulLibraries.OrchardCore/Mvc/OrchardControllerExtensions.cs:12
- Ensure that the LogJsonError method is covered by tests to verify its behavior, especially the serialization of route values.
using System.Text.Json;
OFFI-149