Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust cancel-workflow-on-failure defaults (OSOE-571) #211

Open
0liver opened this issue Feb 15, 2023 · 10 comments
Open

Adjust cancel-workflow-on-failure defaults (OSOE-571) #211

0liver opened this issue Feb 15, 2023 · 10 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@0liver
Copy link
Contributor

0liver commented Feb 15, 2023

Adjust the default value of the cancel-workflow-on-failure workflow parameter based on the usual usage.

We can set it to false for publish-nuget, for example, which is a reusable workflow that will usually be used alone, not as one job among many in a larger workflow (where the workflow cancellation matters). For such workflows, it could even be the default, as well as for create-jira-issues-for-community-activities and validate-submodule-pull-request and validate-pull-request. Check all the existing workflows though.

https://github.com/Lombiq/Open-source-template should also be updated.

Jira issue

@github-actions github-actions bot changed the title Remove the cancel-workflow action from workflows with a single job Remove the cancel-workflow action from workflows with a single job (OSOE-571) Feb 15, 2023
@BenedekFarkas
Copy link
Member

It does cancel other workflows' jobs too, isn't it? In that case it's just a matter of updating the name and maybe adding a description.

@0liver
Copy link
Contributor Author

0liver commented Feb 15, 2023

It does cancel other workflows' jobs too, isn't it?

Oh, right! I overlooked that. I guess, then we don't need to change it (although I agree that it could be named slightly more clearly).

@BenedekFarkas BenedekFarkas changed the title Remove the cancel-workflow action from workflows with a single job (OSOE-571) More descriptive name (and perhaps a description) for "Cancel Workflow on Failure" (OSOE-571) Feb 15, 2023
@Piedone
Copy link
Member

Piedone commented Feb 15, 2023

What name would make it clearer for you?

@0liver
Copy link
Contributor Author

0liver commented Feb 16, 2023

Tbh, looking at this again, I see now that the actions I've referred to will most often be used as part of a larger workflow. Somehow, I missed that.

So I guess, the improvement we could make is setting cancel-workflow-on-failure to false in workflows that contain only a single action. That would help with the status badge on the actions overview page.

@BenedekFarkas
Copy link
Member

BenedekFarkas commented Feb 16, 2023

I think changing that would be problematic if multiple workflows are triggered at the same time (or if that's not the case now, you'd need to remember that when adding a new workflow).

@0liver
Copy link
Contributor Author

0liver commented Feb 16, 2023

I don't quite understand.

@Piedone
Copy link
Member

Piedone commented Feb 16, 2023

We can set it to false for publish-nuget, for example, yes, which is a reusable workflow that will usually be used alone, not as one job among many in a larger workflow (where the workflow cancellation matters). For such workflows, it could even be the default, as well as for create-jira-issues-for-community-activities and validate-submodule-pull-request and validate-pull-request.

@0liver
Copy link
Contributor Author

0liver commented Mar 3, 2023

Do you still deem this important enough to tackle? If yes, we should adjust the title here and in JIRA.

@Piedone Piedone changed the title More descriptive name (and perhaps a description) for "Cancel Workflow on Failure" (OSOE-571) Adjust cancel-workflow-on-failure defaults (OSOE-571) Mar 3, 2023
@Piedone
Copy link
Member

Piedone commented Mar 3, 2023

Updated.

@Piedone Piedone added the good first issue Good for newcomers label Mar 31, 2023
@Piedone
Copy link
Member

Piedone commented Dec 7, 2023

Once done, the "Saving on computing resources" docs section will need to be adjusted too.

@Piedone Piedone added the enhancement New feature or request label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants