Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dot product for i16. #136

Merged
merged 12 commits into from
Oct 1, 2023
Merged

Add dot product for i16. #136

merged 12 commits into from
Oct 1, 2023

Conversation

mcroomp
Copy link
Contributor

@mcroomp mcroomp commented Sep 17, 2023

No description provided.

@mcroomp
Copy link
Contributor Author

mcroomp commented Sep 17, 2023

Temporarily disabled the nightly MIPS tests until this is fixed in the compiler

@CryZe
Copy link
Contributor

CryZe commented Sep 17, 2023

Do you have an upstream ticket for that? If it's indeed an upstream bug, then I'd argue it's very unlikely to be fixed, considering MIPS is basically unmaintained. And without an upstream ticket, even less so. It probably makes sense to rip out this from the CI entirely then. Was it there to test big endian? If so, it should probably be replaced with the much more maintained powerpc targets.

@mcroomp
Copy link
Contributor Author

mcroomp commented Sep 17, 2023

Yeah the MIPS is just to test for endianness.... first thing that came to mind :)

I was going to try to make a simpler repro to file a ticket when I get some time.

@Lokathor
Copy link
Owner

Yeah, MIPS got in the CI as "a big endian target", and doesn't otherwise have a person working on wide that knows any details about it.

@mcroomp
Copy link
Contributor Author

mcroomp commented Sep 26, 2023

Do you have an upstream ticket for that? If it's indeed an upstream bug, then I'd argue it's very unlikely to be fixed, considering MIPS is basically unmaintained. And without an upstream ticket, even less so. It probably makes sense to rip out this from the CI entirely then. Was it there to test big endian? If so, it should probably be replaced with the much more maintained powerpc targets.

Submitted issue... looks like 64 bit shifts in MIPS are broken.
rust-lang/rust#116177

@Lokathor Lokathor merged commit aba67bf into Lokathor:main Oct 1, 2023
24 checks passed
@mcroomp mcroomp deleted the dotproduct branch February 25, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants