Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded duplicate removal #18

Closed
plantformatics opened this issue Aug 11, 2019 · 4 comments
Closed

Hard-coded duplicate removal #18

plantformatics opened this issue Aug 11, 2019 · 4 comments

Comments

@plantformatics
Copy link

Duplicate removal prior to peak calling makes perfect sense when calling peaks on tissue-level ATAC-seq experiments. However, single-cell experiments can retain identical fragments derived from different cells. Thus, I am curious if future releases will be sensitive to this characteristic of single cell ATAC-seq data?

@EvanTarbell
Copy link
Collaborator

That is an excellent point! I will release a new version where duplicate removal is no longer hard-coded and is instead an option settable at runtime.

@plantformatics
Copy link
Author

That would be fantastic! Thanks for the quick response.

@EvanTarbell
Copy link
Collaborator

Version 1.2.6 should take care of this issue now. Thanks

@hmyh1202
Copy link

hmyh1202 commented Sep 5, 2019

nice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants