Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String to BigDecimal deserialize #175

Closed
dosomder opened this issue Feb 19, 2020 · 3 comments · Fixed by #180
Closed

String to BigDecimal deserialize #175

dosomder opened this issue Feb 19, 2020 · 3 comments · Fixed by #180

Comments

@dosomder
Copy link

In our business we are serializing BigDecimal to String with bson4jackson BsonGenerator.Feature.WRITE_BIGDECIMALS_AS_STRINGS

On the other side we require deserializing string to BigDecimal, however, currently this does not work with kmongo. It would be a simple change here:

kmongo/kmongo-jackson-mapping/src/main/kotlin/org/litote/kmongo/jackson/BsonModule.kt

Line 442 in 73b2496

is Double -> BigDecimal(v)

which creates a BigDecimal object from the string.
is String -> BigDecimal(v)

Can this be implemented? Is a PR for this appreciated?
@zigzago
Copy link
Member

zigzago commented Feb 19, 2020

@dosomder a PR would be much appreciated ;)

@dosomder
Copy link
Author

Great. Do you need a test or can I simply add the line?

@zigzago
Copy link
Member

zigzago commented Feb 20, 2020

a test would be great

@dosomder dosomder mentioned this issue Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow string to bigdecimal serialize BertschiAG/kmongo
2 participants
@zigzago @dosomder