This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update block verification - Closes #6754 #6872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Verify the timestamp, height, previousBlockID, generatorAddress, maxHeightPrevoted, maxHeightGenerated, and signature properties - Update interface for bft and validator module API
shuse2
suggested changes
Nov 2, 2021
|
|
Incede
approved these changes
Nov 4, 2021
Incede
reviewed
Nov 4, 2021
Co-authored-by: Incede <[email protected]>
ishantiw
force-pushed
the
6754-update-block-verification
branch
from
83388c0 to
88ecc35
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #6754
How was it solved?
🌱 Add block verification b34b8bd
timestamp,height,previousBlockID,generatorAddress,maxHeightPrevoted,maxHeightGenerated, andsignatureproperties✅ Add all tests for block verification 2ec8bba
How was it tested?
npm run test:unit consensus.spec