Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Missing test cases in state recovery init command #7970

Closed
Tracked by #7245
mitsuaki-u opened this issue Jan 6, 2023 · 1 comment
Closed
Tracked by #7245

Missing test cases in state recovery init command #7970

mitsuaki-u opened this issue Jan 6, 2023 · 1 comment
Assignees
Milestone

Comments

@mitsuaki-u
Copy link
Contributor

Expected behavior

  1. Missing tests from QA sheet:
  • trs.params.chainID is empty
  • `terminatedStateAccount(trs.params.chainID) does not exist (and the previous conditions return True)
  1. Extra exception logic included in code that was not in LIP specs to investigate:
    In verify hook:
		if (!terminatedStateAccount.mainchainStateRoot) {
				throw new Error('Sidechain account has missing property: mainchain state root');
			}

Recommend updating error message to Sidechain account in terminated state has missing property: mainchain state root

Actual behavior

Missing tests

Steps to reproduce

Cross check QA sheet with code

Which version(s) does this affect? (Environment, OS, etc...)

Development

@sitetester
Copy link
Contributor

sitetester commented Oct 9, 2023

Similar task - #8193

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants