Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add dynamic reward module #7717

Closed
Tracked by #7622
shuse2 opened this issue Nov 1, 2022 · 0 comments
Closed
Tracked by #7622

Add dynamic reward module #7717

shuse2 opened this issue Nov 1, 2022 · 0 comments
Assignees
@shuse2
Labels
framework
Milestone
Sprint 81

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Nov 1, 2022 •
edited
Loading

Description

  • Copy src and test for reward module and rename all parts to Dynamic module
  • Update to use dynamic rewards in the default application in application.ts
  • Update beforeTransactionsExecute and afterTransactionsExecute logics
    • it requires 2 new stores in the execute functions

Acceptance Criteria

  • Original reward module is kept as it is
  • Default application uses dynamic reward module
  • New logics are unit tested

Additional Information

All the specification is defined in the proposed LIP
@shuse2 shuse2 moved this to Backlog in Lisk SDK Version 6.0.0 Nov 1, 2022
@shuse2 shuse2 self-assigned this Nov 3, 2022
@shuse2 shuse2 added this to the Sprint 81 milestone Nov 3, 2022
@shuse2 shuse2 mentioned this issue Nov 4, 2022
Merged
shuse2 added a commit that referenced this issue Nov 7, 2022
@shuse2
Add dynamic reward module (#7737)
18f7bbe 
### What was the problem?

This PR resolves #7717 

### How was it solved?

- Add new dynamic reward module using reward module
- Update genesis block for example app
- Add small refactor to reward module to be usable from dynamic reward
module
- Add new DPoS method which is required by dynamic reward module
  - #7715 should add the implementation for `updateSharedRewards`
### How was it tested?

- Add unit tests for all the cases
@shuse2 shuse2 closed this as completed Nov 7, 2022
Repository owner moved this from Backlog to Done in Lisk SDK Version 6.0.0 Nov 7, 2022
@shuse2 shuse2 mentioned this issue Nov 7, 2022
Closed
18 tasks
@sergeyshemyakov sergeyshemyakov mentioned this issue Dec 1, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
framework
Projects
None yet
Milestone
Sprint 81
Development

No branches or pull requests
1 participant
@shuse2