This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Entering a 13-word passphrase would throw an error in the console, preventing further checks.
How did I fix it?
I set up a try/catch statement where the error was being thrown. If an error is caught, the
isValidPassphrase
method returns false. This assumes that if an error is thrown from the mnemonic library, the passphrase is invalid.The error is thrown from a 3rd party lib, so there isn't much that can be done to resolve the issue there.
QUESTION: on line 92, there's a check in place to ensure that the passphrase is greater than or equal to 12 words, based off of spaces. If that check was to verify whether the passphrase contains EXACTLY 12 spaces, this issue could also be resolved. Is there a case where the passphrase can be valid with more than 12 spaces? I was unable to find anything to confirm that.
How to test it?
Review checklist
All new features are covered with e2e testsNo new features