This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Do not show delegate registration form for a delegate - Closes #946 #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves LiskArchive#946. Initially I attempted a redirect to the root page here so the modal wouldn’t load if the user is a delegate. Due to the way this dialog is opened though, that caused the dialog to quickly animate onto the page, then disappear after the redirect was triggered. This is a quick compromise for the UX.
Specs updated to 1) Confirm the InfoParagraph component is loaded when a delegate exists 2) Confirm that the delegate registration form isn’t rendered if the account is already a delegate
reyraa
changed the title
ginacontrino
approved these changes
Nov 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
An existing delegate was able to navigate directly to the register delegate dialog at
/main/voting/register-delegateand view the delegate registration form.How did I fix it?
An informational dialog is displayed stating that the user is already a delegate, and the registration form is no longer shown.
How to test it?
Review checklist
All new features are covered with e2e tests. No new features added