Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Setup testnet tests - Closes #925 #960

Merged
merged 4 commits into from
Nov 7, 2017
Merged

Setup testnet tests - Closes #925 #960

merged 4 commits into from
Nov 7, 2017

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Nov 6, 2017

What was the problem?

We had no configuration for running tests with testnet

How did I fix it?

  • Added scripts so we can run some of the existing voting and sending tests with testnet

How to test it?

Before you run the tests, you should save the passphrase in your env
export TESTNET_PASSPHRASE='recipe bomb asset salon coil symbol tiger engine assist pact pumpkin visit'

  • Then, in order to just run tests with testnet you can go:
    npm run e2e-test -- --disableChecks --cucumberOpts.tags=@testnet --params.network=testnet --params.useTestnetPassphrase=true

  • In order to run tests with the custom node "https://testnet.lisk.io" you can go:
    npm run e2e-test -- --disableChecks --cucumberOpts.tags=@testnet -- --params.liskCoreURL=https://testnet.lisk.io --params.useTestnetPassphrase=true

  • Make also sure that the normal tests still work:
    npm run e2e-test

Review checklist

@ginacontrino ginacontrino self-assigned this Nov 6, 2017
@ginacontrino ginacontrino changed the title Setup testnet tests Setup testnet tests - Closes #925 Nov 6, 2017
Jenkinsfile Outdated
@@ -126,6 +126,14 @@ node('lisk-nano') {
Xvfb :1$N -ac -screen 0 1280x1024x24 &

# Run end-to-end tests

withCredentials([string(credentialsId: 'lisk-nano-testnet-passphrase', variable: 'TESTNET_PASSPHRASE')]) {
Copy link
Contributor

@fchavant fchavant Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to move this withCredentials statement to wrap the whole sh above, i.e. you need to have:

withCredentials([...]) {
    sh '''
        [...]
        npm run --silent e2e-test:testnet:custom -- --params.baseURL file://$WORKSPACE/app/build/index.html --params.liskCoreURL http://127.0.0.1:400$N  --params.testnetPassphrase $TESTNET_PASSPHRASE --params.testnetCustomNode true
        [...]
    '''
}
[...]

@ginacontrino ginacontrino force-pushed the 925-testnet-tests branch 2 times, most recently from e6ced3d to 45241a7 Compare November 6, 2017 15:38
@ginacontrino ginacontrino force-pushed the 925-testnet-tests branch 8 times, most recently from 0251524 to 955ec6d Compare November 7, 2017 09:19
@ginacontrino ginacontrino requested a review from slaweet November 7, 2017 09:24
@ginacontrino ginacontrino force-pushed the 925-testnet-tests branch 3 times, most recently from 88a21a1 to ce4313e Compare November 7, 2017 13:36
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Gina

@ginacontrino ginacontrino merged commit 8a2b116 into 1.3.0 Nov 7, 2017
@ginacontrino ginacontrino deleted the 925-testnet-tests branch November 7, 2017 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants