This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Remove direct calls to methods of components in unit tests - Closes #703 #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
changed the title
yasharAyari
previously approved these changes
Nov 6, 2017
slaweet
approved these changes
Nov 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Preferred is not to call any component method directly in unit tests. same goes for
setStateand other react related methods.How did I fix it?
I'm using enzyme event simulation to trigger all the required changes to test the methods of our components.
How to test it?
Check the code syntax in unit tests. there should be no call for
setState,wrapper.instanceor any of the direct methods of the components.Review checklist
setState,wrapper.instance.