Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Add DevTools Keyboard Shortcut #937

Merged
merged 2 commits into from
Nov 2, 2017
Merged

Add DevTools Keyboard Shortcut #937

merged 2 commits into from
Nov 2, 2017

Conversation

V1shvesh
Copy link
Contributor

@slaweet
Still a wip...
Tell me if adding that electron-localshortcut is cool or not...

@slaweet
Copy link
Contributor

slaweet commented Nov 1, 2017

Hi @V1shvesh,
Thank you for your PR. It's ok to use electron-localshortcut.
Though there is an eslint violation.
You can see it in our Jenkins:
https://jenkins.lisk.io/job/lisk-nano/job/PR-937/1/console
Or when running npm run eslint.

Should be auto-fixable by running npm run eslint -- --fix

@slaweet slaweet self-assigned this Nov 1, 2017
@V1shvesh
Copy link
Contributor Author

V1shvesh commented Nov 1, 2017

Done.
Can you also help me with the other problems I'm facing while solving issue #899 ?

@slaweet slaweet changed the base branch from development to 1.3.0 November 2, 2017 05:31
slaweet
slaweet approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Thank you @V1shvesh

@slaweet slaweet mentioned this pull request Nov 2, 2017
Open
@slaweet slaweet merged commit 8846b77 into LiskArchive:1.3.0 Nov 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees
No one assigned
Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@V1shvesh @slaweet