This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Adding more tests for register component - Closes #839 #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
suggested changes
Oct 10, 2017
| it('should call activePeerSet with testnet if network index is testnet', () => { | ||
| const props = wrapper.find('Passphrase').props(); | ||
|
|
||
| const loginData = stub(Utils, 'getLoginData'); |
There was a problem hiding this comment.
Please move the stub creation to beforeEach block and the stub restore to afterEach block. It avoids some code duplication and makes tests more stable because restore gets called even if there is some error in the middle of the test and no other test is affected. WIth restore inside the test case, in case of error in the test, the stub is not restored and the next test fails too because it is trying to stub something that already is a stub.
slaweet
approved these changes
Oct 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the Problem?
The test coverage of the register component was poor + the component needed some refactoring #839
What did you do?
How can I test this?