-
Notifications
You must be signed in to change notification settings - Fork 60
Setup browser language detector - Closes #556 #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I personally find automatic translations annoying. John Resig seems to agree:
No automatic translations of content to the user’s native language. There is nothing worse than arriving at a site and being forced into a version that you can’t read either because it’s poorly translated, or you’re being GeoIP detected, or you’re on a computer whose language settings don’t match your own. If you visit a URL it should always be in the same language
- In case we decide to do so, we have to modify locale files. presently I have a failing request for
locales/en-US/common.json
while I have it, only in another path.
I think that the "no automatic translations" is valid with websites, but Nano is a desktop app you're unlikely to install on another machine then your own. I will look into a way to resolve locales like |
I still find it annoying even in mobile apps (which run in the most personal medium), but that's a personal opinion, If other teammates consent, I'm down with it. |
As for locales resolving (e.g. |
I gave it some thought and in the end implemented a language switcher dropdown on login page. |
... because language detection will be handled in Electron wrapper
Thanks Vit |
This is the last part left from #556