This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Fix voting tab after migration differences - Close #622 #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
suggested changes
Aug 24, 2017
src/components/voting/voting.css
Outdated
| @@ -50,6 +50,9 @@ | |||
| line-height: 24px; | |||
| margin-left: 6px; | |||
| } | |||
| & :global .disable{ | |||
There was a problem hiding this comment.
Why :global? Cannot it be used as styles.disable instead of 'disable'?
src/components/voting/voting.css
Outdated
| @@ -50,6 +50,9 @@ | |||
| line-height: 24px; | |||
| margin-left: 6px; | |||
| } | |||
| & :global .disable{ | |||
| color: rgba(0,0,0,0.38); | |||
There was a problem hiding this comment.
.disable also needs cursor: default;
src/components/voting/voting.css
Outdated
| /* react toolbar overwroght */ | ||
| .input{ | ||
| margin-top: -15px; | ||
| margin-top: -10px; | ||
| padding-bottom: 5px; |
There was a problem hiding this comment.
IMO it looks better without this padding-bottom override. (I like more the default of 20px)
reyraa
previously approved these changes
Aug 25, 2017
slaweet
approved these changes
Aug 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #622