This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Isolate core and presentational logics - Closes #611, #610, #584 #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Api call to actions
alepop
suggested changes
Aug 23, 2017
src/actions/account.js
Outdated
| dispatch(activePeerReset()); | ||
| dispatch(transactionsReset()); | ||
| dispatch({ type: actionTypes.accountLoggedOut }); | ||
| }; |
There was a problem hiding this comment.
Each dispatch will handle view re-render. I recommend to using one action that will be handled in different reducers. like, handle logout in each of it.
There was a problem hiding this comment.
Good point. I'll change it
src/components/forging/forging.js
Outdated
| import ForgedBlocks from './forgedBlocks'; | ||
|
|
||
| class Forging extends React.Component { | ||
| loadStats(key, startMoment) { |
There was a problem hiding this comment.
Component do not have a state, better use the stateless one
There was a problem hiding this comment.
yeah I forgot to change it
slaweet
suggested changes
Aug 23, 2017
There was a problem hiding this comment.
It looks very good.
I found just this small issue:
- cannot introduced in this PR, but related to 'cleaning store after logout':
actionTypes.activePeerResetshould set peer state to{ data: {}, status: {} }inestead of{ data: null, status: null }because, else there isTypeError: Cannot read property 'online' of nullwhen I log out and log back in.
| wrapper.find('.username input').simulate('change', { target: { value: 'sample_username' } }); | ||
| wrapper.find('.next-button').simulate('click'); | ||
| expect(wrapper.find('.primary-button button').props().disabled).to.not.equal(true); | ||
| // TODO: this doesn't work for some reason | ||
| // expect(props.showSuccessAlert).to.have.been.calledWith(); | ||
| expect(props.delegateRegistered).to.have.been.calledWith(); |
There was a problem hiding this comment.
The TODO comment above can be also removed
| @@ -10,20 +9,31 @@ class Transactions extends React.Component { | |||
| constructor() { | |||
| super(); | |||
| this.canLoadMore = true; | |||
| this.transactionsCount = 0; | |||
src/actions/account.test.js
Outdated
| expect(dispatch).to.have.been.calledWith(forgingReset()); | ||
| expect(dispatch).to.have.been.calledWith(activePeerReset()); | ||
| expect(dispatch).to.have.been.calledWith(transactionsReset()); | ||
| expect(dispatch).to.have.property('callCount', 4); |
There was a problem hiding this comment.
There is also expect(dispatch).to.have.been.called.exactly(4);
alepop
approved these changes
Aug 23, 2017
slaweet
approved these changes
Aug 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #611
Closes #610
Closes #584