Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Fix the Electron app - Closes #539 #614

Merged
merged 4 commits into from
Aug 18, 2017
Merged

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Aug 17, 2017

These three problems have been addressed:

  • Loading css and js with absolute paths
  • Not using location #hash for routing
  • Fonts built by webpack didn't get loaded (solution found by @alepop)

It makes webpack to include them in base64 in styles.css
That solves electron not finding the fonts
Thank you @alepop for the solution
The error was:
Uncaught TypeError: Cannot read property 'NODE_ENV' of null
@slaweet slaweet requested a review from reyraa August 18, 2017 08:00
Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Vit!

@slaweet slaweet merged commit 2c3d897 into development Aug 18, 2017
@slaweet slaweet deleted the 539-fix-electron-app branch August 18, 2017 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants