This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Cetralise test setup - Closes #589 #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
589-cetralise-test-setup
branch
from
3c7d5cf to
a330123
Compare
slaweet
force-pushed
the
589-cetralise-test-setup
branch
from
389c0e0 to
26a90d7
Compare
slaweet
force-pushed
the
589-cetralise-test-setup
branch
from
26a90d7 to
10a2277
Compare
yasharAyari
suggested changes
Aug 25, 2017
| chai.use(chaiEnzyme()); | ||
| chai.use(chaiAsPromised); | ||
| sinonStubPromise(sinon); | ||
|
|
||
| // load all tests into one bundle | ||
| const testsContext = require.context('.', true, /\.test\.js$/); |
There was a problem hiding this comment.
Use es6 import instead of require.
There was a problem hiding this comment.
I don't think it is possible to use import for this task. If you know how, please tell me.
There was a problem hiding this comment.
you can try this https://github.com/crisberrios/dir-loader
There was a problem hiding this comment.
I looked at dir-loader, but it is still using require, so I don't see how does it help.
I don't see what is the problem with the current solution.
yasharAyari
approved these changes
Aug 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #589