This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Move the Login logic to middlewares - Closes #596 #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
added
enhancement
🏗️ in progress
👁️ pending review
and removed
🏗️ in progress
labels
slaweet
suggested changes
Aug 16, 2017
src/store/middlewares/login.js
Outdated
| return getAccount(activePeer, address).then(accountData => | ||
| getDelegate(activePeer, publicKey) | ||
| .then((delegateData) => { | ||
| next(accountLoggedIn(Object.assign({}, accountData, accountBasics, |
There was a problem hiding this comment.
I think it would be better to call store.dispatch(...) than next(...). RIght now it's not a big difference, but once we have more middlewares it will be easier if each action goes through each middleware.
https://stackoverflow.com/questions/40444158/should-you-dispatch-or-call-next-multiple-times-inside-of-a-redux-middleware
src/store/middlewares/login.js
Outdated
| next(accountLoggedIn(Object.assign({}, accountData, accountBasics, | ||
| { delegate: delegateData.delegate, isDelegate: true }))); | ||
| }).catch(() => { | ||
| next(accountLoggedIn(Object.assign({}, accountData, accountBasics, |
src/store/middlewares/login.test.js
Outdated
| middleware(store)(next)(activePeerSetAction); | ||
| expect(next).to.have.been.calledWith(); | ||
|
|
||
| accountApiMock.restore(); |
There was a problem hiding this comment.
This is ok for now.
But for the future, I just discovered a more fault-tolerant and less verbose way to restore stubs, mocks, etc. - sinon-test https://www.npmjs.com/package/sinon-test
slaweet
approved these changes
Aug 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #596