This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Review and improve React unit test coverage - Closes #531 #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasharAyari
suggested changes
Aug 15, 2017
| balance: 1e8, | ||
| }; | ||
| }; | ||
| }); | ||
|
|
||
| it(' should render 3 article tags', () => { |
There was a problem hiding this comment.
Please remove the extra space character before should.
| afterEach(() => { | ||
| accountApiMock.restore(); | ||
| }); | ||
|
|
||
| it('should be called once', () => { | ||
| const actionSpy = spy(AccountComponent.prototype, 'componentDidMount'); |
There was a problem hiding this comment.
You don't need to test 'componentDidMount' because it is part of React and it always runs.You should test functions that call inside the 'componentDidMount'.
|
|
||
| it('calls props.onActivePeerUpdated', () => { | ||
| accountApiMock.expects('getAccountStatus').resolves({ success: true }); | ||
| const wrapper = mount(<Provider store={store}><AccountComponent {...props} /></Provider>); |
There was a problem hiding this comment.
You defined wrapper but you never used it. If it is extra, you need to remove it.
yasharAyari
suggested changes
Aug 15, 2017
| import sinonChai from 'sinon-chai'; | ||
| import { shallow, mount } from 'enzyme'; | ||
| import { Provider } from 'react-redux'; | ||
| import * as accountApi from '../../utils/api/account'; |
There was a problem hiding this comment.
You defined 'accountApi' and 'sinon' and 'mock' but you didn't use them. please remove them.
yasharAyari
approved these changes
Aug 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test coverage is increased to 90%.
There is more room for improving coverage, but there are already over 400 changed lines, so it's worth reviewing and merging. There can be another similar issue opened in the future.
Closes #531