This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Create ActionBar React component - Closes #541 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
suggested changes
Aug 8, 2017
src/components/actionBar/index.js
Outdated
| import grid from 'flexboxgrid/dist/flexboxgrid.css'; | ||
|
|
||
| const ActionBar = props => ( | ||
| <section style={{ margin: '0' }} |
| import chaiEnzyme from 'chai-enzyme'; | ||
| import sinon from 'sinon'; | ||
| import sinonChai from 'sinon-chai'; | ||
| import ActionBar from './'; |
|
|
||
| it('binds props.primaryButton.onClick to second button onClick', () => { | ||
| wrapper.find('Button').at(1).simulate('click'); | ||
| expect(props.primaryButton.onClick).to.have.been.calledWith(); |
There was a problem hiding this comment.
Isn't the primary button disabled?nI was expecting it not to trigger the handler
There was a problem hiding this comment.
It is not. See disabled: false, on line 26.
|
Thanks Vit, there are just a few changes request. |
reyraa
approved these changes
Aug 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #541