This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Invalid timestamp fixes - Closes #365 #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isabello
reviewed
Jul 20, 2017
package.json
Outdated
| @@ -38,7 +38,7 @@ | |||
| "debug": "=2.2.0", | |||
| "jasmine-spec-reporter": "=3.3.0", | |||
| "jquery": "=2.2.4", | |||
| "lisk-js": "=0.4.2", | |||
| "lisk-js": "^0.4.4", | |||
src/services/api/accountApi.js
Outdated
| secondSecret = null) => Peers.sendRequestPromise('transactions', | ||
| { recipientId, amount, secret, secondSecret }); | ||
| secondSecret = null, offsetSeconds = 10) => Peers.sendRequestPromise('transactions', | ||
| { recipientId, amount, secret, secondSecret, offsetSeconds }); |
There was a problem hiding this comment.
Does this cover voting transactions, second sig reg etc? All tx need to use this new property.
reyraa
force-pushed
the
365-invalid-timestamp
branch
from
9e0372a to
d841445
Compare
Isabello
changed the title
yasharAyari
approved these changes
Jul 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lisk-jsto v0.4.4offsetSecondsparameter totransaction.creaseApi (default: 10).Closes "Invalid transaction timestamp" #365