This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Unify "not enough funds" errors - Closes #405 #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
405-not-enough-funds-errors
branch
2 times, most recently
from
7ac7c87 to
da5e7ae
Compare
slaweet
force-pushed
the
405-not-enough-funds-errors
branch
from
da5e7ae to
ee3d27f
Compare
reyraa
suggested changes
Jun 14, 2017
src/components/fee/fee.js
Outdated
| this.account = Account; | ||
| const notEnoughtLSK = lsk.normalize(this.account.get().balance) < this.fee; | ||
|
|
||
| this.text = notEnoughtLSK ? |
There was a problem hiding this comment.
Please fix the typo. Also fix it in L23.
There was a problem hiding this comment.
Also I would suggest insufficientFunds.
src/filters/notEnoughBalance.js
Outdated
| * @module app | ||
| * @submodule notEnoughBalance | ||
| */ | ||
| app.filter('notEnoughBalance', (Account, lsk) => amount => lsk.normalize(Account.get().balance) < amount); |
There was a problem hiding this comment.
And this name can be FundsSufficiency as in Filter by funds sufficiency.
reyraa
approved these changes
Jun 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.