This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Polish voting page - Closes #344 #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yasharAyari
commented
Jun 9, 2017
yasharAyari
commented
- Make the vote checkboxes more prominent (blue like on login page)
- Highlight voted delegate row in blue (similarly to currently used red/green)
- Change "Confirm vote" to "Confirm" in vote dialog button.
slaweet
suggested changes
Jun 12, 2017
| @@ -34,7 +34,7 @@ delegates { | |||
| background-color: rgb(255, 228, 220); | |||
| } | |||
| .pending { | |||
| background-color: #eaeae9; | |||
| background-color: rgb(204, 231, 236); | |||
There was a problem hiding this comment.
Highlight voted delegate row in blue (similarly to currently used red/green)
This was supposed to mean something else. Sorry that my description was ambiguous. Pending votes should stay gray, but not pending placed votes should be blue. That is the state when the checkbox is checked and (currently) the background is white.
Also, I personally find the blue you chose bit too greenish, I like more something like #d6f0ff
…sk-nano into 344-polish-voting-page
slaweet
suggested changes
Jun 12, 2017
| @@ -36,6 +36,9 @@ delegates { | |||
| .pending { | |||
| background-color: #eaeae9; | |||
| } | |||
| .voted{ | |||
There was a problem hiding this comment.
.voted should be defined before .pending in order to have the pending vote gray, not blue.
slaweet
approved these changes
Jun 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.