This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Conform all numbers with comma - Closes #326 #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
suggested changes
Jun 8, 2017
There was a problem hiding this comment.
We must not round LSK to two floating places. LSK has 8 significant floating places and has to be displayed with that precision (if the all the floating places are used). In the future, the price of LSK can be much higher and more floating places are then important.
Also, this PR should not contain commit from the other PR (issue #321).
reyraa
changed the title
slaweet
changed the title
slaweet
reviewed
Jun 9, 2017
src/components/lsk/lsk.pug
Outdated
| @@ -1,2 +1,2 @@ | |||
| span(ng-bind='$ctrl.amount | lsk') | |||
| span(ng-bind='$ctrl.amount | lsk | number:8') | |||
There was a problem hiding this comment.
number:8 is also not the answer as we don't want to show the trailing zeros.
100.00000000 should be 100
100.12300000 should be 100.123
There was a problem hiding this comment.
$ctrl.amount | lsk | number might work
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use angular number filter in lisk and forging component to fix this issue.