This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Fix displaying delegate name - Closes #1080 #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to make sure we won't miss confirmed transactions
- update tests not to use invalid public key (non-hex) - update sign/verify Message tests because the algorithm changed
slaweet
force-pushed
the
1080-fix-delegate
branch
from
4e4847c to
776a137
Compare
faival
approved these changes
Aug 17, 2018
Efefefef
approved these changes
Aug 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
When registering a delegate, it never got the transaction confirmed, thus never showed delegate name and "Forging" tab
How did I fix it?
Similarly to Hub, I stopped checking unconfirmed transactions, so that as long as there is a pending transaction, it will keep trying to fetch confirmed transactions, until the pending transaction is in the confirmed list.
How to test it?
Review checklist