This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Prevent multiple clicks on "send" button - Closes #1036 #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
force-pushed
the
1036-prevent-double-transaction-sent
branch
3 times, most recently
from
fadbfa5 to
d62e4f0
Compare
because it contains fix of a possible double spend
slaweet
force-pushed
the
1036-prevent-double-transaction-sent
branch
from
d62e4f0 to
0e47f8a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Send button could be clicked twice
How did I fix it?
I've set
this.state.ecexutedto disable the send button.How to test it?
To reproduce without the fix, setup dev tools network to have big latency
Review checklist