Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Fix sign message to allow to make changes and sign again #1009

Merged
merged 2 commits into from
Nov 24, 2017
Merged

Fix sign message to allow to make changes and sign again #1009

merged 2 commits into from
Nov 24, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Nov 23, 2017 •
edited
Loading

What was the problem?

Once the "Sign" button was clicked, the user could not change the message and sign again.

How did I fix it?

Show the buttons again if the message is changed.

How to test it?

  • Open sign message dialog
  • Enter a message and sign
  • Change the message and sign again

Review checklist

  • All new code is covered with unit tests
  • All new code follows best practices

@slaweet slaweet self-assigned this Nov 23, 2017
@slaweet slaweet changed the base branch from development to 1.3.0 November 24, 2017 07:15
@ginacontrino ginacontrino self-requested a review November 24, 2017 07:50
ginacontrino
ginacontrino approved these changes Nov 24, 2017
View reviewed changes
Copy link
Contributor

@ginacontrino ginacontrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Thank you

@slaweet slaweet merged commit 10bb97b into 1.3.0 Nov 24, 2017
@slaweet slaweet deleted the sign-message-fix branch November 24, 2017 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ginacontrino ginacontrino ginacontrino approved these changes

Assignees

@slaweet slaweet

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaweet @ginacontrino