Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Fix transaction update problem - Closes #1002 #1004

Merged
merged 3 commits into from
Nov 22, 2017
Merged

Fix transaction update problem - Closes #1002 #1004

merged 3 commits into from
Nov 22, 2017

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Nov 22, 2017 •
edited by slaweet
Loading

What was the problem?

The transactions didn't update for a new user without transactions

How did I fix it?

Added an extra condition to check the transaction count

How to test it?

  • Open nano
  • Select testnet or custom node network
  • Create a new account
  • In another machine, send some LSK to that account
  • Wait for the transaction to arrive

Review checklist

@ginacontrino ginacontrino self-assigned this Nov 22, 2017
@ginacontrino ginacontrino requested a review from slaweet November 22, 2017 13:53
slaweet
slaweet approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ginacontrino

@ginacontrino ginacontrino merged commit ce61079 into 1.3.0 Nov 22, 2017
@ginacontrino ginacontrino deleted the 1002-transaction-update branch November 22, 2017 14:51
@slaweet slaweet changed the title Fix transaction update problem Fix transaction update problem - Closes #1002 Nov 23, 2017
@slaweet slaweet mentioned this pull request Nov 23, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slaweet slaweet slaweet approved these changes

Assignees

@ginacontrino ginacontrino

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ginacontrino @slaweet