Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

E2e test send on testnet #925

Closed
slaweet opened this issue Oct 26, 2017 · 0 comments
Closed

E2e test send on testnet #925

slaweet opened this issue Oct 26, 2017 · 0 comments

Comments

@slaweet
Copy link
Contributor

slaweet commented Oct 26, 2017

There should be some e2e tests that run with testnet:

There should be a way to specify a testnet passphrase as an argument of e2e test command, e.g.:
npm run --silent e2e-test -- --params.testenetPassphrase 'wagon stock borrow episode laundry kitten salute link globe zero feed marble' so that we don't need to have the passphrase in the public source code. In Jenkins we can have the passphrase in an environment variable.

The default of the testenetPassphrase param should be something like null, defined here:
https://github.com/LiskHQ/lisk-nano/blob/d69cc1c2f6baf918c9eaea13bb0f41e6c3b8325c/protractor.conf.js#L23-L27

If the testenetPassphrase param is null, then the step can be marked as pending, using: callback(null, 'pending'); [0], so that it is possible to successfully run the e2e tests without a testnet account.

[0] cucumber/cucumber-js#873 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants