You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
There should be a way to specify a testnet passphrase as an argument of e2e test command, e.g.: npm run --silent e2e-test -- --params.testenetPassphrase 'wagon stock borrow episode laundry kitten salute link globe zero feed marble' so that we don't need to have the passphrase in the public source code. In Jenkins we can have the passphrase in an environment variable.
If the testenetPassphrase param is null, then the step can be marked as pending, using: callback(null, 'pending'); [0], so that it is possible to successfully run the e2e tests without a testnet account.
There should be some e2e tests that run with testnet:
There should be a way to specify a testnet passphrase as an argument of e2e test command, e.g.:
npm run --silent e2e-test -- --params.testenetPassphrase 'wagon stock borrow episode laundry kitten salute link globe zero feed marble'
so that we don't need to have the passphrase in the public source code. In Jenkins we can have the passphrase in an environment variable.The default of the
testenetPassphrase
param should be something likenull
, defined here:https://github.com/LiskHQ/lisk-nano/blob/d69cc1c2f6baf918c9eaea13bb0f41e6c3b8325c/protractor.conf.js#L23-L27
If the
testenetPassphrase
param isnull
, then the step can be marked as pending, using:callback(null, 'pending');
[0], so that it is possible to successfully run the e2e tests without a testnet account.[0] cucumber/cucumber-js#873 (comment)
The text was updated successfully, but these errors were encountered: